Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch from throat to p-limit #12960

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Conversation

joshkel
Copy link
Contributor

@joshkel joshkel commented Jun 23, 2022

Fixes #12757

Summary

Throat has a significant unacknowledged bug (ForbesLindesay/throat#61) that may cause it to lock up with repeated invocations.

Sindre's p-limit appears to be better supported. I picked p-limit 3.x (the last version before the switch to pure ESM) to match Jest's usage of other packages from Sindre.

Test plan

Automated tests pass, and I'm using this fork locally in daily development to ensure that it owrks.

Throat has a significant unacknowledged bug (ForbesLindesay/throat#61) that may cause it to lock up with repeated invocations.

Sindre's p-limit appears to be better supported.  I picked p-limit 3.x (the last version before the switch to pure ESM) to match Jest's usage of other packages from Sindre.

Fixes jestjs#12757
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 30f70cb into jestjs:main Jun 30, 2022
@joshkel joshkel deleted the throat-to-p-limit branch June 30, 2022 13:01
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Watch mode locks up at "Determining test suites to run..." after several activations
3 participants